Storage options text fixups #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
force-pushed
the
storage-location-text
branch
from
ac13dc1 to
9aa1163
Compare
This does away with a loadable detail and places a check mark icon in it's place.
jarolrod
force-pushed
the
storage-location-text
branch
from
9aa1163 to
a9812ff
Compare
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#206 Rebased-From: a9812ff
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#206 Rebased-From: a9812ff
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#206 Rebased-From: a9812ff
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
20b23bc qml: storage options description fixups (Jarol Rodriguez) Pull request description: Based on bitcoin-core/gui-qml#205 so as to not conflict. Only PR commit is ac13dc1da3088099ca9c020f980d3245ac2a3084 Performs small text fixups to the storage options to fall in line with the designs. Only differs from the [figma designs](https://www.figma.com/file/GaCoOSNHB2yMB9ThiDtred/Bitcoin-Core-App?node-id=3288%3A72160&t=ttpjexCKgAerUbB2-0) by changing `For regular wallet use.` to `For simple wallet use.` in the StorageAmount OptionsButton control. ### Master | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 2 12 47 AM" src="https://user-images.githubusercontent.com/23396902/207529947-346fcd7b-4a7c-42bd-aee6-4784b1fbb43a.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 2 12 52 AM" src="https://user-images.githubusercontent.com/23396902/207529982-e4e3faa1-7e24-4460-b5da-1d87ee69dc17.png"> | ### PR | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 2 08 00 AM" src="https://user-images.githubusercontent.com/23396902/207530072-3da9a872-7a76-4ba7-86b0-ba7b3fc48287.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 2 08 18 AM" src="https://user-images.githubusercontent.com/23396902/207530101-5503aa6b-ac23-4d95-976d-7f37f4fb50f0.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/206) ACKs for top commit: johnny9: ACK 20b23bc Tree-SHA512: 3abaf8f6a020823974a60dca1146069a2cdc41c80a9d41621242538251327642678b60907604745a36f86666f7f4af87d09f327305239cdf4090af3be8ced9b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #205 so as to not conflict. Only PR commit is ac13dc1
Performs small text fixups to the storage options to fall in line with the designs. Only differs from the figma designs by changing
For regular wallet use.toFor simple wallet use.in the StorageAmount OptionsButton control.Master
PR